[Mesa-dev] [PATCH] i965/vs: Use the proper dimensionality for the sampler result register.

[Eric Anholt]

On Wed,  4 Jan 2012 04:07:24 -0800, Kenneth Graunke <kenneth at whitecape.org> wrote:
> textureSize() returns an int, ivec2, or ivec3, but never an ivec4.
> Creating the destination register as an ivec4 triggered later failures,
> even though the register did hold the proper values.
> 
> For example, piglit test vs-textureSize-compare calls textureSize on a
> 2D texture and compares the result to an expected value.  Unfortunately,
> our generated code also tried to compare the third and fourth components
> which were undefined, and failed.
> 
> Fixes piglit test vs-textureSize-compare as well as 19 subcases of
> oglconform's glsl-bif-tex-size test.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44339
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

Makes sense to me.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120104/006e4fbd/attachment.pgp>