[Mesa-dev] [PATCH] st/mesa: don't crash when clearing non-existant buffers.

[Brian Paul]

On 01/05/2012 08:53 AM, Dave Airlie wrote:
> From: Dave Airlie<airlied at redhat.com>
>
> this fixes the gl3.0 piglit clearbuffer-depth/stencil/invalid buffer
> tests for gallium drivers.
>
> only question is should mesa be catching this somewhere higher?

Yeah, we should.  In _mesa_Clear() we tell the driver to only clear 
buffers that really exist.  Driver/state-trackers shouldn't have to 
check for non-existant buffers then.

Maybe intead of testing ctx->DrawBuffer->Visual.haveDepthBuffer, etc 
we should test ctx->DrawBuffer->Attachment[BUFFER_DEPTH].Type instead.

I haven't looked into this particular failure though so I'm not sure 
what's going on.

-Brian