[Mesa-dev] [PATCH 1/2] mesa: add missing error check for linear blit of integer colors

Eric Anholt eric at anholt.net
Fri Jan 6 16:36:32 PST 2012


On Fri,  6 Jan 2012 15:34:47 -0700, Brian Paul <brianp at vmware.com> wrote:
> ---
>  src/mesa/main/fbobject.c |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index 912170a..aa35ba7 100644
> --- a/src/mesa/main/fbobject.c
> +++ b/src/mesa/main/fbobject.c
> @@ -2742,6 +2742,18 @@ _mesa_BlitFramebufferEXT(GLint srcX0, GLint srcY0, GLint srcX1, GLint srcY1,
>        }
>     }
>  
> +   if (filter == GL_LINEAR && (mask & GL_COLOR_BUFFER_BIT)) {
> +      /* "Calling BlitFramebuffer will result in an INVALID_OPERATION error
> +       * if filter is LINEAR and read buffer contains integer data."

I couldn't find this piece of text (though I would have hoped it
existed).  Care to cite which spec in the comment?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120106/76558aed/attachment.pgp>


More information about the mesa-dev mailing list