[Mesa-dev] [PATCH 08/11] i965: Move _NEW_PROGRAM dirty bit from gen7_sf_state to gen7_sbe_state.

Kenneth Graunke kenneth at whitecape.org
Mon Jan 9 13:12:27 PST 2012


On 01/09/2012 08:28 AM, Eric Anholt wrote:
> On Sun,  8 Jan 2012 14:43:57 -0800, Kenneth Graunke<kenneth at whitecape.org>  wrote:
>> According to a comment in gen6_sf_state.c, calls to get_attr_override
>> need both _NEW_PROGRAM and _NEW_LIGHT.  Since Gen7 reuses the same
>> function, the same dirty bits should apply.
>>
>> When I performed the SF/SBE split, I partitioned the bits incorrectly:
>> 3DSTATE_SBE (which contains the attribute setup) was missing _NEW_PROGRAM,
>> while 3DSTATE_SF was listing it as a dependency for no reason.
>
> I think the ctx->VertexProgram.PointSizeEnabled in SF is an un-annotated
> dependency on _NEW_PROGRAM.

Whoops.  Yeah.  Will fix before pushing...thanks.


More information about the mesa-dev mailing list