[Mesa-dev] [PATCH] gallivm: add IABS opcode support

[Jose Fonseca]

Test slaves are also reporting similar failures on glean:

  ./glean --run results --overwrite --quick --tests glsl1'
  warning: failed to translate tgsi opcode F2I to LLVM
  warning: failed to translate tgsi opcode IDIV to LLVM
  src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c:2232:emit_instruction: Assertion `0' failed.

TGSI_OPCODE_I2F

Jose

----- Original Message -----
> how did you get gallivm to get this opcode?
> 
> it shouldn't be possible yet, and gallivm needs a lot of work before
> it can do integers.
> 
> Dave.
> 
> On Wed, Jan 11, 2012 at 6:23 PM, nobled <nobled at dreamwidth.org>
> wrote:
> > ---
> >  src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c |    1 +
> >  src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c |    1 +
> >  2 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c
> > b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c
> > index a021efd..88702bc 100644
> > --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c
> > +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c
> > @@ -697,6 +697,7 @@ emit_instruction(
> >       return FALSE;
> >
> >    case TGSI_OPCODE_ABS:
> > +   case TGSI_OPCODE_IABS:
> >       src0 = emit_fetch(bld, inst, 0);
> >       dst0 = lp_build_abs(&bld->base, src0);
> >       break;
> > diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
> > b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
> > index 40744e3..f9dc5b4 100644
> > --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
> > +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
> > @@ -1812,6 +1812,7 @@ emit_instruction(
> >       break;
> >
> >    case TGSI_OPCODE_ABS:
> > +   case TGSI_OPCODE_IABS:
> >       FOR_EACH_DST0_ENABLED_CHANNEL( inst, chan_index ) {
> >          tmp0 = emit_fetch( bld, inst, 0, chan_index );
> >          dst0[chan_index] = lp_build_abs( &bld->base, tmp0 );
> > --
> > 1.7.4.1
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>