[Mesa-dev] [PATCH 2/4] intel: Drop the version override code now that we don't have any left.

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/13/2012 11:00 AM, Kenneth Graunke wrote:
> On 01/12/2012 04:48 PM, Eric Anholt wrote:
>> On Thu, 12 Jan 2012 16:21:59 -0800, Kenneth Graunke<kenneth at whitecape.org>  wrote:
>>> On 01/12/2012 04:08 PM, Eric Anholt wrote:
>>>> Fixes a compiler warning.
>>>> ---
>>>>    src/mesa/drivers/dri/intel/intel_extensions.c |    8 --------
>>>>    1 files changed, 0 insertions(+), 8 deletions(-)
>>>>
>>>> diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c b/src/mesa/drivers/dri/intel/intel_extensions.c
>>>> index 7aa040c..0ce452f 100644
>>>> --- a/src/mesa/drivers/dri/intel/intel_extensions.c
>>>> +++ b/src/mesa/drivers/dri/intel/intel_extensions.c
>>>> @@ -41,14 +41,6 @@ void
>>>>    intelInitExtensions(struct gl_context *ctx)
>>>>    {
>>>>       struct intel_context *intel = intel_context(ctx);
>>>> -   char *override = getenv("MESA_GL_VERSION_OVERRIDE");
>>>> -   int override_major, override_minor;
>>>> -   int override_version = 0;
>>>> -
>>>> -   if (override&&
>>>> -       sscanf(override, "%u.%u",&override_major,&override_minor) == 2) {
>>>> -      override_version = override_major * 10 + override_minor;
>>>> -   }
>>>>
>>>>       ctx->Extensions.ARB_draw_elements_base_vertex = true;
>>>>       ctx->Extensions.ARB_explicit_attrib_location = true;
>>>
>>> I would rather keep this...it seems like it will continue to be useful
>>> as we move on to implementing 3.1, 3.2, 4.0, and so on.  There's not
>>> really a lot gained by removing it, either...
>>
>> git log intel_extensions will find it quickly, and otherwise I'll be
>> seeing this error every compile for the next 3 months.
> 
> Point taken.
> 
> For some reason I was thinking this was the Core mesa code.  But it's obviously not.  I'm okay with dropping this.
> 
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

This is dead code that has been superseded by src/mea/main/version.c:override_version().

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPELQ9AAoJEAIvNt057x8iAs4P/13cQLkh9fFOoqdbNUItK7Tg
92olOV0ce0LTtdY/tBj7lSH5Gea0TOFaMzF741pt+B6+WMjkVRdEVvh152fmD2XH
mSuqauNYqBUqBwatNjiPFFP9l/wPsyFRn9NwsLlpJmcRKMaBOGrYGZ1QnXahC1wQ
Vik+E+ScqR5h0dpS5PQlNMExXuNfWhRlprH0yy2YyYH84+v0ohX34eoTeCzG1HNc
hBn0zyu7UlHtrglU5z402Ncf4p5/uZvTxDXo+KxLzdGF1Qu4tv3cOZFAdfl5iYXY
tkaHNXenEtgYaGDJHKWnjJIAmMCRgbsEfAZqrFPoyFGkfVeHI18+f/EBavySVPGF
QN3hpapuqAlwCG4JQbMnIlbuF5VACHRoJxxw4MAXvu+LbJvH1j7C+onJE+U/auw4
g4v82o2U0ZdsZ/s4+QFOG6HnOy+tOpihaOfCwcyMaPCFZHQSeB20ft5KacZGS4zN
0V0UGj75TdI3PvGlNjd2GpEujMWUIa+yrmvq++59bX5SpASV7lVkiSxqsPTHYqu7
YSmI1D/b3tSnAwx43ZgM6L8wqyzxvdwQaOsv+60P+X4Rsli65B+Eo5UoFrtOlZ7a
sHpMcS5i7MnFNHed5oI5ulpb2HPEzPYEtBUCJ6hMZevzCe/NPtKzVjfR0/GggEDV
AuS7IGwf9S00gmjvh0q3
=65+W
-----END PGP SIGNATURE-----