[Mesa-dev] [PATCH] mesa: Allow texture with zero width/height to create miptree

Anuj Phogat anuj.phogat at gmail.com
Mon Jan 16 11:51:07 PST 2012


TestMipMaps() function in src/OGLconform/textureNPOT.c calls glTexImage2D()
with width = 0. Texture with zero image width skips miptree allocation due to
a condition in function _mesa_store_teximage3d(). While calling glGetTexImage()
it results in assertion failure in intel_map_texture_image() due to null mt
pointer

https://bugs.freedesktop.org/show_bug.cgi?id=42334

Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
---
 src/mesa/main/texstore.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c
index a9c64ce..956276e 100644
--- a/src/mesa/main/texstore.c
+++ b/src/mesa/main/texstore.c
@@ -4601,9 +4601,6 @@ _mesa_store_teximage3d(struct gl_context *ctx,
                        GLenum format, GLenum type, const void *pixels,
                        const struct gl_pixelstore_attrib *packing)
 {
-   if (width == 0 || height == 0 || depth == 0)
-      return;
-
    /* allocate storage for texture data */
    if (!ctx->Driver.AllocTextureImageBuffer(ctx, texImage, texImage->TexFormat,
                                             width, height, depth)) {
-- 
1.7.7.4



More information about the mesa-dev mailing list