[Mesa-dev] [PATCH] mesa: Support GL_VERTEX_ATTRIB_ARRAY_INTEGER in GL 3.0 contexts.

Ian Romanick idr at freedesktop.org
Mon Jan 16 16:36:56 PST 2012


On 01/16/2012 10:38 AM, Kenneth Graunke wrote:
> According to Table 6.8 (Page 348) in the OpenGL 3.0 specification,
> glGetVertexAttribfv supports GL_VERTEX_ATTRIB_ARRAY_INTEGER.
>
> Signed-off-by: Kenneth Graunke<kenneth at whitecape.org>

This patch indirectly affects the oglc depth-tex test (which tries to 
use this function).  I'd like to see a real piglit test. :)  In any case,

Tested-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
>   src/mesa/main/varray.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
> index 540e896..9078d11 100644
> --- a/src/mesa/main/varray.c
> +++ b/src/mesa/main/varray.c
> @@ -555,7 +555,7 @@ get_vertex_array_attrib(struct gl_context *ctx, GLuint index, GLenum pname,
>      case GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING_ARB:
>         return array->BufferObj->Name;
>      case GL_VERTEX_ATTRIB_ARRAY_INTEGER:
> -      if (ctx->Extensions.EXT_gpu_shader4) {
> +      if (ctx->VersionMajor>= 3 || ctx->Extensions.EXT_gpu_shader4) {
>            return array->Integer;
>         }
>         goto error;



More information about the mesa-dev mailing list