[Mesa-dev] [PATCH] mesa: increase size of TFB info Outputs array

[Christoph Bumiller]

On 01/17/2012 05:50 PM, Christoph Bumiller wrote:
> On 01/12/2012 10:53 PM, Christoph Bumiller wrote:
>> The nvc0 gallium driver is advertising 128 MAX_INTERLEAVED_COMPS
>> which made it always assert in the linker when TFB was used.
>>
> 
> Going to push this soon if no one minds ... though maybe I should just
> change the limit in the driver to 64, this struct uses up quite a lot of
> space with this large array.
> 
> But then, if people cared about memory usage the whole transform
> feedback info would be allocated dynamically wouldn't it ...
> 

Sent another patch to have the array allocated dynamically (mesa:
allocate transform_feedback_info::Outputs array dynamically), maybe
that's nicer ...

> 
>> The new size corresponds to the maximum number of possible unique
>> outputs when varying packing is used.
>>
>> NOTE: This is a candidate for the 8.0 branch.
>> ---
>>  src/mesa/main/mtypes.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
>> index 9fdabf9..f677461 100644
>> --- a/src/mesa/main/mtypes.h
>> +++ b/src/mesa/main/mtypes.h
>> @@ -1846,7 +1846,7 @@ struct gl_transform_feedback_info {
>>         * offset is in the y and z components of the output register.
>>         */
>>        unsigned ComponentOffset;
>> -   } Outputs[MAX_PROGRAM_OUTPUTS];
>> +   } Outputs[MAX_PROGRAM_OUTPUTS * 4];
>>  
>>     /** Transform feedback varyings used for the linking of this shader program.
>>      *
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev