[Mesa-dev] [PATCH] i965/vs: Take attributes into account when deciding urb_entry_size.

Eric Anholt eric at anholt.net
Wed Jan 18 09:44:34 PST 2012


On Tue, 17 Jan 2012 22:10:07 -0800, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Both the VF and VS share space in the URB.  First, the VF stores
> attributes (shader inputs) there.  The VS then reads the attributes,
> executes, and reuses the space to store varyings (shader outputs).
> 
> Thus, we need to calculate the amount of URB space necessary for inputs,
> outputs, and pick whichever is greater.
> 
> The old VS backend correctly did this (brw_vs_emit.c:408), but the new
> VS backend only considered outputs.
> 
> Fixes vertex scrambling in GLBenchmark PRO on Ivybridge.
> 
> NOTE: This is a candidate for the 8.0 branch.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120118/000bc39f/attachment.pgp>


More information about the mesa-dev mailing list