[Mesa-dev] [PATCH] mesa: Set default access flags based on the run-time API

[Brian Paul]

On 01/18/2012 12:41 PM, Ian Romanick wrote:
> From: Ian Romanick<ian.d.romanick at intel.com>
>
> The default access flags for OpenGL ES (via GL_OES_map_buffer) and
> desktop OpenGL are different.  The code previously tried to handle
> this, but the decision was made at compile time.  Since the same
> driver binary can be used for both OpenGL ES and desktop OpenGL, the
> decision must be made at run-time.
>
> This should fix bug #44433.  It appears that the test case does
> various map and unmap operations and inspects the state of the buffer
> object around each.  When it sees that GL_BUFFER_ACCESS does not match
> its expectations, it fails.
>
> NOTE: This is a candidate for release branches.
>
> Signed-off-by: Ian Romanick<ian.d.romanick at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44433
> ---
> v2: Convert DEFAULT_ACCESS macro to default_access_mode inline
> function.  Add text from the relevant specs justifying the code.
>


Reviewed-by: Brian Paul <brianp at vmware.com>