[Mesa-dev] [PATCH 5/7] automake: src/mesa/drivers/dri/nouveau

[Gaetan Nadon]

On 12-01-17 08:30 PM, Matt Turner wrote:
> On Tue, Jan 17, 2012 at 7:32 PM, Gaetan Nadon <memsize at videotron.ca> wrote:
>> On 12-01-17 03:58 PM, Matt Turner wrote:
>>
>> +AM_CPPFLAGS = \
>> +	-I$(top_srcdir)/include \
>> +	-I$(top_srcdir)/src/ \
>> +	-I$(top_srcdir)/src/mapi \
>> +	-I$(top_srcdir)/src/mesa/ \
>> +	-I../common \
>>
>> Why does this one cannot be written properly based on top_srcdir?
> It can. I suppose not writing it in terms of top_srcdir would break
> out-of-tree builds?
Generally speaking, yes. There are cases where it will and cases where
it won't as automake tries to correct dangerous situations. Using
top_srcdir and top_builddir appropriately is always safe and easier to
read than a bunch of ../../../
>
> Thanks,
> Matt
>

Thanks for listening!