[Mesa-dev] [PATCH] mesa: Loosen glBlitFramebuffer restrictions on depthstencil buffers (v2)

[Eric Anholt]

On Thu, 19 Jan 2012 21:12:31 +0100, Christoph Bumiller <e0425955 at student.tuwien.ac.at> wrote:
> On 19.01.2012 19:53, Ian Romanick wrote:
> > On 01/18/2012 12:31 PM, Chad Versace wrote:
> >> --- snip
> >>
> >> Supporting Z32 ->  Z32_FLOAT is a bad idea. So I've amended the patch
> >> to avoid that.
> >>
> >> --- end snip
> >>
> >>
> >> This loosens the format validation in glBlitFramebuffer. When blitting
> >> depth bits, don't require an exact match between the depth formats; only
> >> require that the two formats have the same number of depth bits and the
> >> same depth datatype (float vs uint). Ditto for stencil.
> >>
> >> Between S8_Z24 buffers, the EXT_framebuffer_blit spec allows
> >> glBlitFramebuffer to blit the depth and stencil bits separately. So I
> >> see
> >> no reason to prevent blitting the depth bits between X8_Z24 and
> >> S8_Z24 or
> >> the stencil bits between S8 and S8_Z24. However, we of course don't want
> >> to allow blitting from Z32 to Z32_FLOAT.
> >>
> 
> So is it also allowed to blit from S8Z24 to Z24S8 ? Could we also allow
> to blit from RGBA8 to BGRA8 then, please ?

That's already allowed.

    If the color formats of the read and draw framebuffers do not
    match, and <mask> includes COLOR_BUFFER_BIT, the pixel groups are
    converted to match the destination format as in CopyPixels, except
    that no pixel transfer operations apply and clamping behaves as if
    CLAMP_FRAGMENT_COLOR_ARB is set to FIXED_ONLY_ARB.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120119/48989865/attachment.pgp>