[Mesa-dev] [PATCH 2/3] r600g: replace trans/vector-only instruction lists with ranges

Christian König deathsimple at vodafone.de
Sun Jan 22 08:20:28 PST 2012


On 22.01.2012 16:46, Dave Airlie wrote:
> 2012/1/22 Christian König<deathsimple at vodafone.de>:
>> Sorry, but that looks really ugly and pretty much unmaintainable, cause you
>> constantly need to lookup the meaning of the values.
>>
>> Also I haven't looked into the docs (but going to do so tomorrow), but I'm
>> pretty sure that those ranges aren't 100% correct.
> It was the docs that the ranges came from, and we keep forgetting to
> add things to these lookup functions.

Really? Where? I asked around when I coded this in the first place if it 
could be simplified by using ranges, but never got an clear answer on 
this topic.

When I now look into the AMD docs they mostly seems to use tables for 
opcode attributes, so I assumed that they are spread around in the 
opcode range.

If this isn't the case then this indeed seems to be an good idea.

Christian.


More information about the mesa-dev mailing list