[Mesa-dev] [PATCH] i965: fix inverted point sprite origin when rendering to FBO

Kenneth Graunke kenneth at whitecape.org
Sun Jan 22 23:13:35 PST 2012


On 01/19/2012 03:48 PM, Yuanhan Liu wrote:
> When rendering to FBO, rendering is inverted. At the same time, we would
> also make sure the point sprite origin is inverted. Or, we will get an
> inverted result correspoinding to rendering to the default winsys FBO.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44613
>
> NOTE: This is a candidate for stable release branches.
>
> v2: add the simliar logic to ivb, too (comments from Ian)
>      simplify the logic operation (comments from Brian)
>
> v3: pick a better comment from Eric
>      use != for the logic instead of ^ (comments from Ian)
>
> Signed-off-by: Yuanhan Liu<yuanhan.liu at linux.intel.com>
> ---
>   src/mesa/drivers/dri/i965/brw_defines.h   |    1 +
>   src/mesa/drivers/dri/i965/gen6_sf_state.c |   13 +++++++++++--
>   src/mesa/drivers/dri/i965/gen7_sf_state.c |   18 +++++++++++++++---
>   3 files changed, 27 insertions(+), 5 deletions(-)

v3 looks great!  Thanks for finding this.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>



More information about the mesa-dev mailing list