[Mesa-dev] [PATCH 2/5] st/mesa: require all s3tc formats for EXT_texture_compression_s3tc

[Brian Paul]

On Sun, Jan 22, 2012 at 4:36 PM, Marek Olšák <maraeo at gmail.com> wrote:
> ---
>  src/mesa/state_tracker/st_extensions.c |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c
> index 12fce86..6c8a491 100644
> --- a/src/mesa/state_tracker/st_extensions.c
> +++ b/src/mesa/state_tracker/st_extensions.c
> @@ -436,7 +436,16 @@ void st_init_extensions(struct st_context *st)
>    }
>
>    /* s3tc support */
> -   if (screen->is_format_supported(screen, PIPE_FORMAT_DXT5_RGBA,
> +   if (screen->is_format_supported(screen, PIPE_FORMAT_DXT1_RGB,
> +                                   PIPE_TEXTURE_2D, 0,
> +                                   PIPE_BIND_SAMPLER_VIEW) &&
> +       screen->is_format_supported(screen, PIPE_FORMAT_DXT1_RGBA,
> +                                   PIPE_TEXTURE_2D, 0,
> +                                   PIPE_BIND_SAMPLER_VIEW) &&
> +       screen->is_format_supported(screen, PIPE_FORMAT_DXT3_RGBA,
> +                                   PIPE_TEXTURE_2D, 0,
> +                                   PIPE_BIND_SAMPLER_VIEW) &&
> +       screen->is_format_supported(screen, PIPE_FORMAT_DXT5_RGBA,
>                                    PIPE_TEXTURE_2D, 0,
>                                    PIPE_BIND_SAMPLER_VIEW) &&
>        (ctx->Mesa_DXTn || st_get_s3tc_override())) {
> --

Just curious: is this just for the sake of completeness or some other reason?

Reviewed-by: Brian Paul <brianp at vmware.com>