[Mesa-dev] [PATCH 2/6] draw: Don't revalidate pipeline on backend flushes

[Jose Fonseca]

Looking at the source code, DRAW_FLUSH_* flags were clearly intended as a bitmask. Maybe flags combinations are never used, but for future proof sake, bitwise arithmetic should be used for draw flush flags, instead of == or !=, in this and other patches of this series.

Jose 

----- Original Message -----
> From: Jakob Bornecrantz <wallbraker at gmail.com>
> 
> Reviewed-by: Stéphane Marchesin <marcheu at chromium.org>
> Tested-by: Stéphane Marchesin <marcheu at chromium.org>
> ---
>  src/gallium/auxiliary/draw/draw_pipe.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/draw/draw_pipe.c
> b/src/gallium/auxiliary/draw/draw_pipe.c
> index f1b0171..3bf68a1 100644
> --- a/src/gallium/auxiliary/draw/draw_pipe.c
> +++ b/src/gallium/auxiliary/draw/draw_pipe.c
> @@ -344,5 +344,6 @@ void draw_pipeline_flush( struct draw_context
> *draw,
>                            unsigned flags )
>  {
>     draw->pipeline.first->flush( draw->pipeline.first, flags );
> -   draw->pipeline.first = draw->pipeline.validate;
> +   if (flags != DRAW_FLUSH_BACKEND)
> +      draw->pipeline.first = draw->pipeline.validate;
>  }
> --
> 1.7.6.5
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>