[Mesa-dev] [PATCH 2/2 v2] swrast: Use fixed-function processing instead _TexEnvProgram for DrawPixels

[Brian Paul]

On Mon, Jan 23, 2012 at 6:19 PM, Ian Romanick <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> This is a hack to work around drivers such as i965 that:
>
>    - Set _MaintainTexEnvProgram to generate GLSL IR for
>      fixed-function fragment processing.
>    - Don't call _mesa_ir_link_shader to generate Mesa IR from the
>      GLSL IR.
>    - May use swrast to handle glDrawPixels.
>
> Since _mesa_ir_link_shader is never called, there is no Mesa IR to
> execute.  Instead do regular fixed-function processing.
>
> Even on platforms that don't need this, the software fixed-function
> code is much faster than the software shader code.
>
> NOTE: This is a candidate for the 8.0 branch.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44749

LGTM.  Reviewed-by: Brian Paul <brianp at vmware.com>