[Mesa-dev] [PATCH] i965/gen6: Fix segfault in transform feedback to DYNAMIC_DRAW buffers.

Eric Anholt eric at anholt.net
Tue Jan 24 10:12:38 PST 2012


On Mon, 23 Jan 2012 16:25:23 -0800, Paul Berry <stereotype441 at gmail.com> wrote:
> When storing data in a buffer of type DYNAMIC_DRAW, we don't create a
> drm_intel_bo for it; instead we store the data in system memory and
> defer allocation of the GPU buffer until it is needed.  Therefore, in
> brw_update_sol_surface(), we can't just consult the "buffer" field of
> the intel_buffer_object structure; we need to call
> intel_bufferobj_buffer() to ensure that the deferred allocation
> occurs.
> 
> This parallels a similar fix for gen7 (see commit ba6f4c9).
> 
> Fixes piglit test EXT_transform_feedback/buffer-usage on gen6.
> 
> This is a candidate for the 8.0 release branch.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120124/c92868f7/attachment-0001.pgp>


More information about the mesa-dev mailing list