[Mesa-dev] [PATCH 2/2] i965: Drop the buggy, verbose link test for unresolved symbols.
Eric Anholt
eric at anholt.net
Tue Jan 24 10:09:30 PST 2012
This mostly existed to cause a build error when you typoed a function
name, didn't see the warning in the Mesa build spew, then some time
later tried to use your driver and it failed in a strange way. Now
that we enable errors on missing prototypes, the problem that this was
fixing should be gone.
(Of course, -Werror=missing-prototypes isn't a complete solution for
avoiding unresolved symbols -- maybe you have a prototype, but never
wrote the implementation. Still, that wasn't the failure mode we
cared about when this link test was added)
---
src/mesa/drivers/dri/i965/Makefile.am | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am
index 5512381..5387824 100644
--- a/src/mesa/drivers/dri/i965/Makefile.am
+++ b/src/mesa/drivers/dri/i965/Makefile.am
@@ -65,15 +65,6 @@ i965_dri_la_LIBADD = \
$(DRICORE_LIB_DEPS) \
$(INTEL_LIBS)
-# Test build to make sure that we didn't leave any undefined symbols in the
-# driver.
-noinst_PROGRAMS = i965_symbols_test
-
-i965_symbols_test_SOURCES = \
- ../common/dri_test.c
-i965_symbols_test_LDADD = \
- i965_dri.la
-
# Provide compatibility with scripts for the old Mesa build system for
# a while by putting a link to the driver into /lib of the build tree.
all-local: i965_dri.la
--
1.7.7.3
More information about the mesa-dev
mailing list