[Mesa-dev] [PATCH 1/4] glapi: remove non-existent parameter references

[nobled]

On Tue, Jan 17, 2012 at 6:10 PM, Brian Paul <brianp at vmware.com> wrote:
> On 01/16/2012 04:45 PM, nobled wrote:
>>
>> glGetTexImage, for example, has no width/height/depth parameters.
>>
>> Also, copy some missing parameter info from the original versions
>> of certain functions over to their ARB_robustness counterparts.
>
>
> These look OK to me.  There's no real change in the generated .[ch] files,
> right?
Hmm. Okay, weirdly, it actually does seem to have an effect. It
changes __glXReadPixelReply to __glXReadReply, mostly. And I'm not
sure if the new code is equivalent because I'm not even sure how this
works right now. (For example, it doesn't seem to call
xcb_glx_get_histogram() with enough parameters[it's missing the last
one, 'reset'], and with this change it calls it with even one fewer --
no more 'state->storePack.swapEndian'.)

Difference attached.

(I could just run `make mesa`, it turns out.)
>
> -Brian
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-regen-code-for-glapi-remove-non-existent-parameter-r.patch
Type: text/x-patch
Size: 13926 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120124/af4f9bff/attachment-0001.bin>