[Mesa-dev] [PATCH 4/4] glapi: add GL_ARB_texture_compression_rgtc

[nobled]

On Thu, Jan 19, 2012 at 1:46 PM, Eric Anholt <eric at anholt.net> wrote:
> On Mon, 16 Jan 2012 18:50:44 -0500, nobled <nobled at dreamwidth.org> wrote:
>> Noticed this was missing when writing the "glapi: sort ARB extensions
>> by number" commit, which at least shows it was effective.
>> ---
>>  .../glapi/gen/ARB_texture_compression_rgtc.xml     |   15 +++++++++++++++
>>  src/mapi/glapi/gen/Makefile                        |    1 +
>>  src/mapi/glapi/gen/gl_API.xml                      |    2 +-
>>  3 files changed, 17 insertions(+), 1 deletions(-)
>>  create mode 100644 src/mapi/glapi/gen/ARB_texture_compression_rgtc.xml
>>
>> diff --git a/src/mapi/glapi/gen/ARB_texture_compression_rgtc.xml
>> b/src/mapi/glapi/gen/ARB_texture_compression_rgtc.xml
>> new file mode 100644
>> index 0000000..f0ecabd
>> --- /dev/null
>> +++ b/src/mapi/glapi/gen/ARB_texture_compression_rgtc.xml
>> @@ -0,0 +1,15 @@
>> +<?xml version="1.0"?>
>> +<!DOCTYPE OpenGLAPI SYSTEM "gl_API.dtd">
>> +
>> +<OpenGLAPI>
>> +
>> +<category name="GL_ARB_texture_rgtc" number="52">
>
> missing "compression"?
>
>> +
>> +    <enum name="COMPRESSED_RED_RGTC1"        value = "0x8DBB"/>
>> +    <enum name="COMPRESSED_SIGNED_RED_RGTC1" value = "0x8DBC"/>
>> +    <enum name="COMPRESSED_RG_RGTC2"         value = "0x8DBD"/>
>> +    <enum name="COMPRESSED_SIGNED_RG_RGTC2"  value = "0x8DBE"/>
>> +
>> +</category>
>> +
>> +</OpenGLAPI>
>
> I don't understand how the XML is used well enough to review this
> series, really.
It just adds new table entries in the regenerated
src/mesa/main/enums.c file, it doesn't touch anything else.