[Mesa-dev] [PATCH 3/4] mesa: remove ctx->Const.sRGBCapable
Dave Airlie
airlied at gmail.com
Wed Jan 25 00:03:22 PST 2012
On Wed, Jan 25, 2012 at 6:58 AM, Dave Airlie <airlied at gmail.com> wrote:
> On Wed, Jan 25, 2012 at 1:53 AM, Ian Romanick <idr at freedesktop.org> wrote:
>> On 01/24/2012 04:39 PM, Marek Olšák wrote:
>>>
>>> It always had the same value as ctx->Extensions.EXT_framebuffer_sRGB.
>>
>>
>> I'd be curious why Dave added this flag in the first place. It's... odd.
>> In any case,
>
> So would I, but I think I was going to use it for something to do with
> the GLX extension, but my memory is pretty vague on the subject like
> most.
Hey I even wrote it in the commit message at the time,
"This adds i965 support for GL_EXT_framebuffer_sRGB, it introduces a new
constant to say that the driver can support sRGB enabled FBOs since enabling
the extension doesn't mean the driver can actually support sRGB."
You can expose the interface on a non-capable driver and just refuse
to accept sRGB buffers.
So the flag is technically right. Whether it is useful is another question.
Dave.
More information about the mesa-dev
mailing list