[Mesa-dev] [PATCH 2/2] scons: don't add -Wmissing-field-initializers

[Marek Olšák]

The warning is absolutely useless. It doesn't actually say that there are
uninitialized variables. It points out the fact that there are missing
initializers and that variables are initialized to zero implicitly, which is
exactly what we want and what we commonly make use of.

C90 and C99 require all unspecified variables in the initializer list to be set
to zero. {} and {0} are valid alternatives to memset. Period.
---
 scons/gallium.py |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/scons/gallium.py b/scons/gallium.py
index 86adc3e..eed89cf 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -364,10 +364,6 @@ def generate(env):
             '-Wmissing-prototypes',
             '-std=gnu99',
         ]
-        if distutils.version.LooseVersion(ccversion) >= distutils.version.LooseVersion('4.0'):
-            ccflags += [
-                '-Wmissing-field-initializers',
-            ]
         if distutils.version.LooseVersion(ccversion) >= distutils.version.LooseVersion('4.2'):
             ccflags += [
                 '-Wpointer-arith',
-- 
1.7.5.4