[Mesa-dev] [PATCH] swrast: Fix fixed-function fragment processing

[Eric Anholt]

On Wed, 25 Jan 2012 19:38:10 -0800, Chad Versace <chad.versace at linux.intel.com> wrote:
> On i965, _mesa_ir_link_shader is never called. As a consequence,
> ctx->FragmentProgram->_Current exists but contains no instructions. This
> greatly confuses swrast.

I don't think this is valid.  You're replacing checks for "is there a
fragment shader" with "is there a fragment shader with Mesa IR?".  I
think the replacement should be the logic that was in
shade_texture_span(): "is there a fragment shader that isn't the fixed
function fragment shader?":

> -   const bool use_fragment_program =
> -      ctx->FragmentProgram._Current
> -      && ctx->FragmentProgram._Current != ctx->FragmentProgram._TexEnvProgram;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120126/80e85cae/attachment.pgp>