[Mesa-dev] [PATCH 2/4] mesa: Add a flag for forcing all GLSL extensions to "warn".

[Ian Romanick]

On 01/25/2012 02:29 PM, Eric Anholt wrote:
> ---
>   src/glsl/glsl_parser_extras.cpp |    3 +++
>   src/mesa/main/mtypes.h          |    6 ++++++
>   2 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp
> index 0b53232..7f8d47c 100644
> --- a/src/glsl/glsl_parser_extras.cpp
> +++ b/src/glsl/glsl_parser_extras.cpp
> @@ -114,6 +114,9 @@ _mesa_glsl_parse_state::_mesa_glsl_parse_state(struct gl_context *ctx,
>      }
>
>      this->supported_version_string = supported;
> +
> +   if (ctx->Const.ForceGLSLExtensionsWarn)
> +      _mesa_glsl_process_extension("all", NULL, "warn", NULL, this);

For what it's worth, I don't think we correctly generate these warnings. :(

>   }
>
>   const char *
> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
> index a2b01d0..99dcb38 100644
> --- a/src/mesa/main/mtypes.h
> +++ b/src/mesa/main/mtypes.h
> @@ -2772,6 +2772,12 @@ struct gl_constants
>      GLuint GLSLVersion;  /**<  GLSL version supported (ex: 120 = 1.20) */
>
>      /**
> +    * Changes default GLSL extension behavior from "error" to "warn".  It's out
> +    * of spec, but it can make some apps work that otherwise wouldn't.
> +    */
> +   GLboolean ForceGLSLExtensionsWarn;
> +
> +   /**
>       * Does the driver support real 32-bit integers?  (Otherwise, integers are
>       * simulated via floats.)
>       */