[Mesa-dev] [PATCH] swrast: Fix fixed-function fragment processing

[Eric Anholt]

On Thu, 26 Jan 2012 12:46:03 -0800, Chad Versace <chad.versace at linux.intel.com> wrote:
> On i965, _mesa_ir_link_shader is never called. As a consequence, the
> current fragment program (ctx->FragmentProgram->_Current) exists but does
> not differ from the fixed function fragment program
> (ctx->FragmentProgram->_TexEnvProgram). This confuses swrast.

I'd say "As a consequence, the current gl_fragment_program exists but is
invalid because its instructions were never filled in.  Avoid using the
empty program when possible by checking that the fragment shader is not
a translation of the current fixed function state.  This should also
result in some performance improvement by taking advantage of custom
fixed function paths where previously the Mesa IR interpreter was used."

I think it makes sense to me how the _swrast_update_fragment_program
hunk is needed.  So:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120126/6339b2a3/attachment.pgp>