[Mesa-dev] [PATCH 01/14] mesa: remove LSB-first pixel packing check in glReadPixels

Ian Romanick idr at freedesktop.org
Fri Jan 27 10:45:49 PST 2012


For the series,

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 01/26/2012 07:04 PM, Brian Paul wrote:
> GL_UNPACK_LSB_FIRST only applies to bitmap data, not glReadPixels.
> ---
>   src/mesa/main/readpix.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
> index c1489d2..84b5224 100644
> --- a/src/mesa/main/readpix.c
> +++ b/src/mesa/main/readpix.c
> @@ -213,8 +213,7 @@ fast_read_rgba_pixels_memcpy( struct gl_context *ctx,
>         return GL_FALSE;
>
>      /* check for things we can't handle here */
> -   if (packing->SwapBytes ||
> -       packing->LsbFirst) {
> +   if (packing->SwapBytes) {
>         return GL_FALSE;
>      }
>



More information about the mesa-dev mailing list