[Mesa-dev] [PATCH 1/2] i965/fs: Fix rendering corruption in unigine tropics.

Kenneth Graunke kenneth at whitecape.org
Fri Jan 27 13:29:18 PST 2012


On 01/27/2012 01:16 PM, Eric Anholt wrote:
> We were allocating registers into the MRF hack region, resulting in
> sparkly renering in a few of the scenes.  We could do better
> allocation by making an MRF class, having MRFs conflict with the
> corresponding GRFs, and tracking the live intervals of the "MRF"s and
> setting up the conflicts.  But this is way easier for the moment.
>
> NOTE: This is a candidate for the 8.0 branch.

Ugh. :(  Thanks for taking care of this. I agree that this is the best 
approach for now.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

I am a bit concerned, though: why would it register allocate out of the 
top 16 GRFs unless it needed that many?  By lowering the ceiling, won't 
we run out of registers entirely?  We don't support spilling on Gen7 
yet...I've been meaning to get around to implementing that.


More information about the mesa-dev mailing list