[Mesa-dev] [PATCH 1/2] mesa: Fix bad-enum/no-buffer error handling for buffer object functions.

Brian Paul brian.e.paul at gmail.com
Mon Jan 30 17:12:14 PST 2012


On Mon, Jan 30, 2012 at 4:25 PM, Eric Anholt <eric at anholt.net> wrote:
> For all the extension entrypoints using the get_buffer() helper, they
> wanted the same error handling.  In some cases, the error was doing
> the same error return whether target was a bad enum, or a user buffer
> wasn't bound.
>
> (Actually, GL_ARB_map_buffer_range doesn't specify the error for a zero
> buffer being bound for MapBufferRange, though it does for
> FlushMappedBufferRange.  This appears to be an oversight).
>
> Fixes piglit GL_ARB_copy_buffer/negative-bound-zero.
> ---
>  src/mesa/main/bufferobj.c |  126 ++++++++++++++-------------------------------
>  1 files changed, 39 insertions(+), 87 deletions(-)

Looks good.  For both: Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the mesa-dev mailing list