[Mesa-dev] [PATCH] i965: fix transform feedback with primitive restart

Kenneth Graunke kenneth at whitecape.org
Sun Jul 1 16:18:29 PDT 2012


On 06/28/2012 04:12 PM, Jordan Justen wrote:
> When querying GL_PRIMITIVES_GENERATED, if primitive restart
> is also used, then take the software primitive restart
> path so GL_PRIMITIVES_GENERATED is returned correctly.
> 
> GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN is also updated
> since it will also affected by the same issue.
> 
> As noted in brw_primitive_restart.c, with further work we
> should be able to move this situation back to a hardware
> handled path.
> 
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_context.h           |    2 ++
>  src/mesa/drivers/dri/i965/brw_primitive_restart.c |   12 ++++++++++++
>  src/mesa/drivers/dri/i965/brw_queryobj.c          |    4 ++++
>  3 files changed, 18 insertions(+)

Wow.  This was a lot simpler than I thought.  Nice interim solution;
hopefully we can get the actual hardware counters working though.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>




More information about the mesa-dev mailing list