[Mesa-dev] [PATCH 4/9] automake: convert libmesa and libmesagallium

[Eric Anholt]

Jon TURNEY <jon.turney at dronecode.org.uk> writes:
> diff --git a/src/mesa/Makefile.am b/src/mesa/Makefile.am
> index bada760..08beaa6 100644
> --- a/src/mesa/Makefile.am
> +++ b/src/mesa/Makefile.am

> +libmesa_la_SOURCES = \
> +	$(MESA_FILES) \
> +	$(MESA_CXX_FILES) \
> +        $(MESA_ASM_FILES_FOR_ARCH)
> +
> +libmesa_la_LIBADD = $(top_builddir)/src/glsl/libglsl.la
> +libmesa_la_LDFLAGS = -static

Doesn't this -static result in relocations for static libs getting
built, which would then be a problem for the linking into shared
libraries later?  I don't really know this stuff well, but a -static in
the middle of a shared lib build seems strange.

The helper lib for the asm code in libdricore built a .a file without
-static being specified.

Also, with this commit, did you test that git_sha1 depencies were
working correctly and commit --amending would produce a new sha1 in your
drivers?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120709/6f182152/attachment.pgp>