[Mesa-dev] [PATCH 1/2] i965: Rip out system memory backing for buffer objects; just use BOs.

[Kenneth Graunke]

On 07/09/2012 11:18 AM, Kenneth Graunke wrote:
> In one workload, 45% of CPU time was spent in pwrite(), primarily
> uploading large amounts of VBO data.  This was in fact the hottest path
> in the application, according to sysprof.  Removing the system memory
> buffer and just storing VBOs in actual BOs cut the application's CPU
> usage by about half, and moved pwrite down to about 2.5% of CPU time.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/intel/intel_buffer_objects.c |  117 +--------------------
>  src/mesa/drivers/dri/intel/intel_buffer_objects.h |    3 -
>  2 files changed, 4 insertions(+), 116 deletions(-)
> 
> Here's my version of the same patch.  It's quite a bit more invasive,
> but it deletes all the code made dead by the change in Eric's patch.

Eric rightly pointed out that this code is still needed by i915.  So,
NAK on my patch 1/2, and

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

on Eric's patch.