[Mesa-dev] [PATCH 1/5] mesa: Fold texcompress_etc1_tmp.h into texcompress_etc.c

Kenneth Graunke kenneth at whitecape.org
Tue Jul 10 11:42:09 PDT 2012

On 07/09/2012 10:46 AM, Chad Versace wrote:
> The header defined the functions in with C-style macro templates. Since
> there was only one user of the header, the templates were unnecessary.
> This patch redefines the functions as vanilla, non-templated functions.
> This patch also removes the header and folds its contents into
> texcompress_etc.c.  The header defined many inline helper functions for
> texcompress_etc.c, but, since no other file included it, it never made
> sense to keep the header separate from the .c file.
> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
> ---
>  src/mesa/main/texcompress_etc.c     | 119 +++++++++++++++++++++++++++++--
>  src/mesa/main/texcompress_etc_tmp.h | 136 ------------------------------------
>  2 files changed, 112 insertions(+), 143 deletions(-)
>  delete mode 100644 src/mesa/main/texcompress_etc_tmp.h

This is also used by src/gallium/auxiliary/util/u_format_etc.c.

Otherwise, this series looks good to me!
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

More information about the mesa-dev mailing list