[Mesa-dev] [PATCH 00/10] ARB_transform_feedback3 & ARB_transform_feedback_instanced

[Ian Romanick]

On 07/10/2012 07:49 AM, Marek Olšák wrote:
> Hi,
>
> I plan to push this series in two days if there's no other feedback.

The architecture looks okay.  I haven't had a chance to review it in 
depth.  Call it

Acked-by: Ian Romanick <ian.d.romanick at intel.com>

> Marek
>
> On Thu, Jul 5, 2012 at 1:20 PM, Marek Olšák <maraeo at gmail.com> wrote:
>> Hi everyone,
>>
>> the title says it all. These are the remaining transform feedback extensions from GL4. Nothing needs to be done for this in drivers, provided they fully implement the internal interfaces.
>>
>> This doesn't add support for multiple vertex streams. It seems like ARB_transform_feedback3 adds vertex streams, but it only adds the API. The main part of the functionality is defined in ARB_gpu_shader5.
>>
>> There are new tests for this on the piglit mailing list.
>>
>> Please review.
>>
>> Marek Olšák (10):
>>        glapi: add ARB_transform_feedback3
>>        glapi: add ARB_transform_feedback_instanced
>>        glsl: implement ARB_transform_feedback3 in the linker
>>        mesa: implement glGet queries and error handling for ARB_transform_feedback3
>>        mesa: implement indexed query functions from ARB_transform_feedback3
>>        mesa: implement display list support for indexed query functions
>>        mesa: implement display list support for new DrawTransformFeedback functions
>>        mesa: implement new DrawTransformFeedback functions
>>        mesa: add ARB_transform_feedback_instanced extension enable flag
>>        st/mesa: expose new transform feedback extensions
>>
>>   src/glsl/linker.cpp                    |  119 ++++++++++++++++++++++++++----
>>   src/mapi/glapi/gen/gl_API.xml          |   50 ++++++++++++-
>>   src/mesa/main/api_validate.c           |   26 +++++--
>>   src/mesa/main/api_validate.h           |    4 +-
>>   src/mesa/main/context.c                |    1 +
>>   src/mesa/main/dd.h                     |    8 ++
>>   src/mesa/main/dlist.c                  |  125 +++++++++++++++++++++++++++++++-
>>   src/mesa/main/extensions.c             |    2 +
>>   src/mesa/main/get.c                    |    9 +++
>>   src/mesa/main/mtypes.h                 |    3 +
>>   src/mesa/main/queryobj.c               |   81 +++++++++++++++++----
>>   src/mesa/main/transformfeedback.c      |   32 ++++++++
>>   src/mesa/main/vtxfmt.c                 |    5 ++
>>   src/mesa/state_tracker/st_extensions.c |    6 ++
>>   src/mesa/vbo/vbo_exec_array.c          |   62 ++++++++++++++--
>>   src/mesa/vbo/vbo_save_api.c            |   45 +++++++++++-
>>   16 files changed, 533 insertions(+), 45 deletions(-)
>>
>> Marek
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>