[Mesa-dev] [PATCH 2/9] automake: convert libglsl

Jon TURNEY jon.turney at dronecode.org.uk
Fri Jul 13 04:59:32 PDT 2012


On 12/07/2012 20:03, Matt Turner wrote:
> make: *** No rule to make target `../../glsl/glsl_lexer.cpp', needed
> by `glsl_lexer.lo'.  Stop.
> 
> which is that obnoxious problem where we renamed .lpp -> .ll and .ypp
> -> .yy since... scons.
> 
> automake creates .cc files from .ll and .yy, and .cpp from .lpp and
> .ypp, so we're generating .cc files.
> 
> Solutions:
>  - We can apply a patch like what I've attached
>  - We can make links from .ll -> .lpp and .yy -> .ypp and make
> automake use the .?pp files
>  - Fix scons and rename the files back to .?pp

For the record, the problem with scons is that if I just rename .ll to .lpp,
scons complains: "Don't know how to build from a source file with suffix
`.lpp'.  Expected a suffix in this list: ['.lm', '.ll', '.yy']."

This is sad, as I tend to think that the third option would be the cleanest,
at least that consistently names all the files .cpp in gsls/, but
unfortunately it seems we don't know how to fix it.

> Please squash those in (or let's find another solution to the .ll
> problem) and slap a Tested-by: Matt Turner <mattst88 at gmail.com> on the
> series.

Thanks for taking the time to test these changes.

I've pushed them now, and look forward to fixing whatever kind of obscure
breakage they cause :-)


More information about the mesa-dev mailing list