[Mesa-dev] [PATCH] Fix build to use glsl_parser.hh instead of glsl_parser.h.

Ian Romanick idr at freedesktop.org
Sat Jul 14 22:21:31 PDT 2012


On 07/13/2012 03:03 PM, Jon TURNEY wrote:
> On 13/07/2012 22:23, Marcin Baczyński wrote:
>> Commit 68e04cc6014bf7a2c9bd0b3b783b4ec12aa2e824 changed .cpp -> .cc,
>> but forgot to update references .h -> .hh.

Header files are named .h.  NAK changes to .hh or .hpp.  Seriously,

>> Also update Doxygen and .gitignore.
>>
>> Signed-off-by: Marcin Baczyński <marbacz at gmail.com>
>
> Thanks, and sorry for the breakage.
>
> But this patch isn't right, as the name of the header file depends on the
> automake version. While automake 1.12 names the output .hh, earlier versions
> named the output .h, which is very inconvenient and why this wasn't spotted in
> testing :-(
>
> doxygen/glsl.doxy exclude definitely needs updating though, thanks for
> spotting that.
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list