[Mesa-dev] [PATCH] Fix build to use glsl_parser.hh instead of glsl_parser.h.

Ian Romanick idr at freedesktop.org
Mon Jul 16 12:45:23 PDT 2012


On 07/16/2012 11:20 AM, Kenneth Graunke wrote:
> On 07/16/2012 10:21 AM, Matt Turner wrote:
>> On Mon, Jul 16, 2012 at 10:14 AM, Ian Romanick <idr at freedesktop.org> wrote:
>>> Nice.  That works for me.  Has a bug been reported to automake?
>>
>> I emailed the automake mailing list and asked how to handle this and
>> the response received made it seem to me that this change was
>> intentional. :(
>>
>>> Also, could we do something similar to avoid more .cc files?  The assembly
>>> parser and lexer (in src/mesa/program/) are going to get converted to C++
>>> soon, and I'd prefer to keep .cpp as our C++ extension.
>>
>> We can, but do we really want to do some extra work to select the file
>> extension of some generated code?
>
> I really don't care about .cc, .hh, or whatever as long as it's
> generated code that we don't edit.  I'd advocate for doing whatever's
> the easiest solution.  If it were code that's actually checked in, I
> would probably actually care.

Header files are different because we actually say the name of them in 
other source files.  I'll concede on the .cc vs .cpp issue for generated 
files.

> It's unfortunate that these tools have hardcoded conventions...yy/cc/hh
> or cpp/cpp/hpp for C++, and y/c/h for C only.  Irritating, but that's
> how it goes I guess...


More information about the mesa-dev mailing list