[Mesa-dev] [PATCH 6/6] intel: Add a comment explaining why we early return on matching BO names.

Chad Versace chad.versace at linux.intel.com
Mon Jul 16 15:02:39 PDT 2012


From: Eric Anholt <eric at anholt.net>

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
---
 src/mesa/drivers/dri/intel/intel_context.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
index 2494ac7..378859c 100644
--- a/src/mesa/drivers/dri/intel/intel_context.c
+++ b/src/mesa/drivers/dri/intel/intel_context.c
@@ -893,6 +893,10 @@ intel_process_dri2_buffer(struct intel_context *intel,
    if (!rb)
       return;
 
+   /* We try to avoid closing and reopening the same BO name, because the first
+    * use of a mapping of the buffer involves a bunch of page faulting which is
+    * moderately expensive.
+    */
    if (rb->mt &&
        rb->mt->region &&
        rb->mt->region->name == buffer->name)
-- 
1.7.11.2



More information about the mesa-dev mailing list