[Mesa-dev] [PATCH] msaa: Generate proper error for operations prohibited on MSAA buffers.

[Kenneth Graunke]

On 07/16/2012 01:36 PM, Paul Berry wrote:
> From the GL 3.0 spec, section 4.3.3, in the documentation for
> CopyPixels():
> 
>     "An INVALID_OPERATION error will be generated if the object bound
>     to READ_FRAMEBUFFER_BINDING is framebuffer complete and the value
>     of SAMPLE_BUFFERS is greater than zero."
> 
> The same applies to CopyTexImage...() and CopyTexSubImage...()
> functions, since they are defined in terms of CopyPixels().
> 
> Previously we were generating an INVALID_FRAMEBUFFER_OPERATION error
> in these cases.
> 
> Fixes piglit tests
> "EXT_framebuffer_multisample/negative-{copypixels,copyteximage}".

Looks right to me.  I'm guessing INVALID_FRAMEBUFFER_OPERATION was the
result of cut and pasting from other error conditions.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>