[Mesa-dev] [PATCH 2/2] glapi/glx: call __glEmptyImage if USE_XCB, not memcpy directly (#52059)

[Julien Cristau]

On Thu, Jul 19, 2012 at 09:39:09 -0700, Ian Romanick wrote:

> On 07/19/2012 07:46 AM, Julien Cristau wrote:
> >From: Julien Cristau <julien.cristau at logilab.fr>
> >
> >We were stomping on the caller's buffer by ignoring their alignment
> >requests.  This patch makes the USE_XCB path match the older one more
> >closely.
> >
> >Signed-off-by: Julien Cristau <julien.cristau at logilab.fr>
> 
> Say
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=52059
> 
> here instead of mentioning the bug in the subject.
> 
Will do.

[...]
> >+						print '        __glEmptyImage(gc, 3, %s, %s, %s, %s, %s, %s_data(reply), %s);' % (w, h, d, output.img_format, output.img_type, xcb_name, output.name)
> 
> I was going to comment that 'dim' should be the second parameter to
> __glEmptyImage instead of hardcoding 3, but it looks like the dim
> parameter isn't used in __glEmptyImage.  I think I can recommend a
> follow-on patch. :)
> 
Ack.

> >+					else:
> >+						s = output.size() / output.get_element_count()
> 
> I don't see where this variable is used.
> 
Right, I'll drop it.

Thanks!

Cheers,
Julien