[Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

[Jerome Glisse]

On Thu, Jul 19, 2012 at 10:06 PM, Marek Olšák <maraeo at gmail.com> wrote:
> I actually care a lot about lockups. Well, you are complaing about
> lockups, yet you have quite obvious bugs in your hyperz code, so let's
> fix them first. (I wouldn't even try and run the hyperz code in its
> current state. Please don't take that personally.) Then, if the
> lockups persist, we can start looking into *what* fixes them. You seem
> to think that this patch helps a lot, but you don't say why. Aren't
> you interested in what sequence of GPU commands helps? If I am
> counting correctly, there are 7 changes in behavior in this patch. It
> should be pretty easy to nail down the few that help, document them
> (like /* these two lines fix a lockup with hyperz */), and discard the
> rest. The documenting part is very important, so that the other
> developers won't break your code accidentally.
>
> Marek
>

You haven't even try hyperz and you say i have an obvious bug, that's
kind of funny, but you would not know why. I try pretty much all of
the thing my patch do in isolation and combination of each other and
the only way i got improvement is with something similar to this
patch. Remove one things and i can find things program that are more
likely to lockup.

Cheers,
Jerome