[Mesa-dev] [PATCH] i830: Fix stack corruption
Chad Versace
chad.versace at linux.intel.com
Fri Jul 20 16:01:05 PDT 2012
On 07/20/2012 03:53 PM, Brian Paul wrote:
> On 07/20/2012 04:45 PM, Chad Versace wrote:
>> Found by compiler warning:
>> i830_texstate.c:131:28: warning: argument to 'sizeof' in 'memset' call
>> is the same expression as the destination; did you mean to
>> dereference it? [-Wsizeof-pointer-memaccess]
>> memset(state, 0, sizeof(state));
>> ~~~~~ ^~~~~
>
> Huh, I've never seen that one before. Is that something new in recent gcc? I
> like it.
I compiled with clang. On the terminal, the messages have pretty colors too :)
>> On 64-bit systems, memset here would write an extra 4 bytes.
>
> Candidate for 8.0 branch?
Thanks for the reminder. I'll add the tag when I push it.
More information about the mesa-dev
mailing list