[Mesa-dev] [PATCH] i830: Fix stack corruption

Chad Versace chad.versace at linux.intel.com
Fri Jul 20 16:30:54 PDT 2012


On 07/20/2012 04:18 PM, Matt Turner wrote:
> On Fri, Jul 20, 2012 at 3:45 PM, Chad Versace
> <chad.versace at linux.intel.com> wrote:
>> Found by compiler warning:
>>     i830_texstate.c:131:28: warning: argument to 'sizeof' in 'memset' call
>>           is the same expression as the destination; did you mean to
>>           dereference it?  [-Wsizeof-pointer-memaccess]
>>        memset(state, 0, sizeof(state));
>>               ~~~~~            ^~~~~
>>
>> On 64-bit systems, memset here would write an extra 4 bytes.


> Reviewed-by: Matt Turner <mattst88 at gmail.com>
> 
> I don't guess there are any 64-bit systems with i915s in them though, are there?

Doh.
/blush




More information about the mesa-dev mailing list