[Mesa-dev] [PATCH 07/10] i965/blorp: Don't fall back to swrast when miptrees absent.

Chad Versace chad.versace at linux.intel.com
Tue Jul 24 09:59:27 PDT 2012


On 07/18/2012 08:15 AM, Paul Berry wrote:
> Previously, the blorp engine would fall back to swrast if the source
> or destination of a blit had no associated miptree.  This was
> unnecessary, since _mesa_BlitFramebufferEXT() already takes care of
> making the blit silently succeed if there are no buffers bound, so the
> fallback paths could never actually happen in practice.
> 
> Removing these fallback paths will simplify the implementation of
> correct DrawBuffers support in blorp.

The presence of the `if (!src_mt) return false` checks made the code seem unsure
of itself without justification. Every intel_renderbuffer, at least in i965, has
a miptree. Having a fallback for the impossible case where that doesn't hold
felt wrong. Good to see that check removed.

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>




More information about the mesa-dev mailing list