[Mesa-dev] [PATCH 08/10] i965/blorp: Rearrange order of blit validation and preparation steps.

[Chad Versace]

On 07/18/2012 08:15 AM, Paul Berry wrote:
> This patch rearranges the order of steps performed by a blorp blit
> from this:
> 
> - Sync up state of window system buffers.
> - Find buffers.
> - Find miptrees.
> - Make sure buffer formats match.
> - Handle mirroring.
> - Make sure width and height match.
> - Handle clipping/scissoring.
> - Account for window system origin conventions.
> - Do depth resolves, if applicable.
> - Do the blit.
> - Record the need for a future HiZ resolve, if applicable.
> 
> To this:
> 
> - Sync up state of window system buffers.
> - Handle mirroring.
> - Make sure width and height match.
> - Handle clipping/scissoring.
> - Account for window system origin conventions.
> - Find buffers.
> - Make sure buffer formats match.
> - Find miptrees.
> - Do depth resolves, if applicable.
> - Do the blit.
> - Record the need for a future HiZ resolve, if applicable.
> 
> The steps are the same, but they are now performed in an order that
> will make it possible to implement correct DrawBuffers support.  Note
> that the last four steps are now in a separate function
> (do_blorp_blit), since they will need to be executed repeatedly when
> DrawBuffers support is added.
> ---
>  src/mesa/drivers/dri/i965/brw_blorp_blit.cpp |  142 ++++++++++++++++----------
>  1 files changed, 87 insertions(+), 55 deletions(-)


> +static bool
> +formats_match(GLbitfield buffer_bit, struct gl_renderbuffer *src_rb,
> +              struct gl_renderbuffer *dst_rb)
> +{
> +   /* Note: don't just check gl_renderbuffer::Format, because some formats
> +    * that are multiple gl_formats that resolve to the same native type in the
         ^^^^
Too many occurences of "that". I think that one needs removal.

> +    * miptree (for example MESA_FORMAT_X8_Z24 and MESA_FORMAT_S8_Z24).
> +    */
> +   return find_miptree(buffer_bit, src_rb)->format ==
> +      find_miptree(buffer_bit, dst_rb)->format;
> +}

Other than the typo,
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>