[Mesa-dev] [PATCH 00/15] i965: Enable window system multisampling

[Paul Berry]

On 21 July 2012 17:36, Chad Versace <chad.versace at linux.intel.com> wrote:

> No Piglit regressions on Ivybridge.
>
> Tested with `glxgears -samples 1`.
>
> Passes 53/70 of oglconform's winsys multisample tests. The failing tests
> mostly consist of those that call glDrawPixels on the depth and stencil
> buffer (which fail due to a swrast fallback) or do fancy things with the
> msaa alpha enums (which also fail with non-winsys msaa).
>
> We probably need to write some Piglit tests for some winsys msaa corner
> cases,
> but I think the series is good enough to push now based on the evidence of
> oglconform's pass rate.
>
> Chad Versace (15):
>   intel: Remove dead code in intelAllocateBuffer
>   intel: Decrease nesting level in intelCreateBuffer
>   intel: Use consistent pattern in intelCreateBuffer
>   intel: Refactor quantize_num_samples
>   intel: Set num samples for winsys renderbuffers
>   intel: Add intel_mipmap_tree::singlesample_mt
>   intel: Refactor creation of hiz and mcs miptrees
>   intel: Allocate miptree for multisample DRI2 buffers
>   i965: Add function intel_miptree_downsample
>   i965: Mark winsys MSAA color buffer as needing resolve postdraw
>   intel: Downsample during glReadPixels
>   intel: Downsample on DRI2 flush
>   intel: Refactor creation of DRI2 configs
>   intel: Refactor intel_screen_make_configs
>   intel: Advertise multisample DRI2 configs on gen >= 6
>

To update the list on what Chad and I discussed in person today:

Patches 1-7, 9, and 12-13 are

Reviewed-by: Paul Berry <stereotype441 at gmail.com>

I have some concerns about patches 8, 10, and 11 which I've already emailed
you about.

I don't feel qualified to review patches 14-15, but fortunately Ian and
Eric already seem to be weighing in on those patches.

You and I discovered this morning that patch 15 introduces a bug with
gnome--it makes gnome-terminal windows fail to show up when using the gnome
compositing window manager.  The bug seems to be related to where the
multisampled visuals appear in the list of visuals, and we suspect that
some part of gnome is erroneously relying on the visuals being in a certain
order.  I will try to investigate this bug as soon as I get a chance
(partly because I think you are busier than me these days, and partly
because I think it will be educational for me).  I'll keep you posted on my
progress.

If things get too busy for you and you want me to take over the patch
series, let me know.  For now I'll assume you still own the patch series,
and I'm just providing troubleshooting assistance :)


>
>  src/mesa/drivers/dri/i965/Makefile.sources      |   1 +
>  src/mesa/drivers/dri/i965/brw_blorp_orphans.cpp |  66 +++
>  src/mesa/drivers/dri/i965/brw_draw.c            |  17 +-
>  src/mesa/drivers/dri/intel/intel_context.c      |  26 +-
>  src/mesa/drivers/dri/intel/intel_fbo.c          |  58 +--
>  src/mesa/drivers/dri/intel/intel_fbo.h          |   8 +-
>  src/mesa/drivers/dri/intel/intel_mipmap_tree.c  |  82 ++++
>  src/mesa/drivers/dri/intel/intel_mipmap_tree.h  |  39 ++
>  src/mesa/drivers/dri/intel/intel_screen.c       | 540
> +++++++++++++-----------
>  src/mesa/drivers/dri/intel/intel_screen.h       |   3 +
>  10 files changed, 536 insertions(+), 304 deletions(-)
>  create mode 100644 src/mesa/drivers/dri/i965/brw_blorp_orphans.cpp
>
> --
> 1.7.11.2
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120725/39bcc746/attachment.html>