[Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

Kenneth Graunke kenneth at whitecape.org
Thu Jul 26 11:05:30 PDT 2012


On 07/26/2012 09:52 AM, Eric Anholt wrote:
> If you want to change your compiler arguments, just set CFLAGS/CXXFLAGS.
> Having Mesa have this separate variable is a great way to have your arguments
> not thoroughly propagated to all compiler invocations.
> ---
> 
> I don't feel strongly about removing the variable from configure, just
> as long as we don't have to propagate it into Makefiles.  I use shared
> configure args including CFLAGS and CXXFLAGS across many projects, so
> I've never seen the use for this one, but if people really care to
> keep it, we should just append it to CFLAGS/CXXFLAGS in configure.ac.

I'm okay with removing it.  Both of these are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

The only concern I have is that this conflicts with Marek's patch to
make --enable-32-bit work, which would be good to have.



More information about the mesa-dev mailing list