[Mesa-dev] [PATCH 14/15] intel: Refactor intel_screen_make_configs

Chad Versace chad.versace at linux.intel.com
Thu Jul 26 17:39:32 PDT 2012


On 07/23/2012 01:35 PM, Ian Romanick wrote:
> On 07/21/2012 05:36 PM, Chad Versace wrote:
>> Transform the code from clever, obfuscated, and imperative to
>> straight-forward and table-driven.
> 
> Does the output of glxinfo change?  It's somewhat advantageous for the IDs
> associated with a specific set of values to remain the same.  We have a lot of
> bug reports, for example, that list specific IDs.  It makes it a lot easier to
> reproduce the bugs that way.

Ok. In the final patch, I'll be sure to verify that the config order remains
unchanged.

I'm rewriting this patch based on Eric's feedback, so I'll CC you on v2.


More information about the mesa-dev mailing list