[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47375

--- Comment #42 from Barto <mister.freeman at laposte.net> 2012-07-27 01:40:32 PDT ---
(In reply to comment #40)

> 
> --- a/src/mesa/drivers/common/meta.c
> +++ b/src/mesa/drivers/common/meta.c
> @@ -2280,8 +2280,7 @@ _mesa_meta_DrawPixels(struct gl_context *ctx,
>      * Determine if we can do the glDrawPixels with texture mapping.
>      */
>     fallback = GL_FALSE;
> -   if (ctx->_ImageTransferState ||
> -       ctx->Fog.Enabled) {
> +   if (ctx->Fog.Enabled) {
>        fallback = GL_TRUE;
>     }

congratulations !

I used your patch and now all is ok with blender and mesa 8.0.4,

blender is now very fast, no lag in GUI, it's great !

a simple change in src/mesa/drivers/common/meta.c seems to speed up blender :

the good conditionnal in line 2256 seems to fix the lag in blender :

 if (ctx->Fog.Enabled) { 
      fallback = GL_TRUE;
   }

I think the bug is solved now with these 2 changes :

1) the fix from Brian solves the crash at startup ( adding this line in
radeon_span.c, after the line 68 :

rrb->base.ColorType = GL_UNSIGNED_BYTE; ) 

2) and this optimization from Roland solves the slowness :

 if (ctx->Fog.Enabled) { 
      fallback = GL_TRUE;
   }

in meta.c at line 2256

thank you both

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.